Riverlea rollout - set as the default theme from 6.0 (but freeze on Greenwich for existing installs using Greenwich) - #31979

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

➡️ Online demo of this PR 🔗

+1 for auto-enabling on new installations

+1 for locking-in the setting on upgraded sites for continuity.

I suspect the test failures are more around swapping the interpretation of default and/or re-arranging other metadata -- which sounds nice, but isn't as urgent. (That kind of thing feels like it would be better at the start of a cycle rather than the end.)

The patch sort of swaps the hard-dependency in Civi\Core\Themes from greenwich to riverlea. I would tempted to relax that dependency, eg master...totten:civicrm-core:master-theme-default

Possible alternative: #31985

I had a higher level thought...

In the hope of explaining, lets distinguish between:

• the Civi::settings "default" for 'theme_frontend' and 'theme_backend'
• the stuff in Civi::themes called DEFAULT_THEME which corresponds setting the value of those settings to default. lets call that 'automatic' instead (thats the label in display settings)

Now, automatic purports to be "get the latest and greatest theme at the discretion of civicrm.org". But the first time in 5(?) years that latest amd greatest is changing, we arent actually exercising that discretion.

So... maybe we just get rid of Automatic? The other PR would mean new installs have an explicit theme choice, we want to flick people who were on Automatic to explicit Greenwich anyway for safety. I dont think an explicit theme choice is likely to pick Automatic (except in the spirit of "I wonder what this does")

So rather than adding more code to automatic I would suggest removing entirely. Migrate people currently on Automatic to Greenwich. Switch the setting level default to minetta. One less option in the UI, one less layer of default (over the settings default), one less line in the settings meta that says 'default' => 'default'

There's already the fallback handling which seems to work ok if your theme setting doesnt correspond to an theme that exists. (Your proposed change looks to me like it belongs more in fallback than default)

The patch sort of swaps the hard-dependency in Civi\Core\Themes from greenwich to riverlea. I would tempted to relax that dependency,

100% that makes more sense. I like the idea of basically removing it because then we don't actually need any required theme extensions. If people want to remove Greenwich and Riverlea, that's kinda reasonable from a system perspective.

Closing in favour of #31986

(Just keeping discussion on this PR so its mainly in one place)

There's already the fallback handling which seems to work ok if your theme setting doesnt correspond to an theme that exists. (Your proposed change looks to me like it belongs more in fallback than default)

I'd misunderstood how this was working. But I looked at a bit more and I think ufundo#9 clears it up and might be the simplest neatest way to handle "you've picked a theme which doesn't exist".